Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Aug 8, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

folkertdev and others added 30 commits July 19, 2025 01:50
so that we get more parallelism out of cargo
work around not being able to project into SIMD values
we use `std::sync::LazyLock` now.
`intrinsic-test`: remove `lazy_static` dependency
This updates the rust-version file to 5a30e43.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 5a30e43
Filtered ref: 59749e9f8c765d3021796a9fe0c188643c4b8d77

This merge was created using https://github.com/rust-lang/josh-sync.
Like any other non-temporal instructions this has additional safety requirements
due to the mismatch with the Rust memory model. It is vital to know when using
this instruction.
Add non-temporal note for maskmoveu_si128
loongarch: Use unified data types for SIMD intrinsics
`intrinsic-test`: combine rust files for faster compilation
…-test-argument-cleanup

Feat: updated Argument<T> type for functional compatibility with other architectures
…-test-generate-only-support

`intrinsic-test`: bringing back support for  --generate-only flag
Use GitHub app for authenticating sync workflows
This updates the rust-version file to 32e7a4b.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 32e7a4b
Filtered ref: 56d8aa13f54944edb711f3bdd7013b082dbaa65b

This merge was created using https://github.com/rust-lang/josh-sync.
rust-bors bot added a commit that referenced this pull request Aug 8, 2025
Rollup of 19 pull requests

try-job: test-various
try-job: dist-ohos-x86_64
@rust-bors
Copy link

rust-bors bot commented Aug 8, 2025

☀️ Try build successful (CI)
Build commit: ba2c375 (ba2c375dd35c299b9c57e479879d5314fc4083f9, parent: 2fd855fbfc8239285aa2d596f76a8cc75e17ce02)

@bors
Copy link
Collaborator

bors commented Aug 8, 2025

⌛ Testing commit f6283ae with merge 2886b36...

@bors
Copy link
Collaborator

bors commented Aug 8, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 2886b36 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 8, 2025
@bors bors merged commit 2886b36 into rust-lang:master Aug 8, 2025
12 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 8, 2025
Copy link
Contributor

github-actions bot commented Aug 8, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 67d45f4 (parent) -> 2886b36 (this PR)

Test differences

Show 347 test diffs

Stage 1

  • [coverage-map] tests/coverage/mcdc/if.rs: pass -> [missing] (J0)
  • [coverage-map] tests/coverage/mcdc/nested_if.rs: pass -> [missing] (J0)
  • [coverage-run] tests/coverage/mcdc/condition-limit.rs: ignore (ignored when the profiler runtime is not available) -> [missing] (J0)
  • [coverage-run] tests/coverage/mcdc/if.rs: ignore (ignored when the profiler runtime is not available) -> [missing] (J0)
  • [coverage-run] tests/coverage/mcdc/non_control_flow.rs: ignore (ignored when the profiler runtime is not available) -> [missing] (J0)
  • [ui] tests/ui/consts/module-const-array-size-13763.rs: [missing] -> pass (J0)
  • [ui] tests/ui/drop/panic-during-drop-14875.rs: [missing] -> pass (J0)
  • [ui] tests/ui/inference/matcher-lifetime-inference-14919.rs: [missing] -> pass (J0)
  • [ui] tests/ui/instrument-coverage/coverage-options.rs#mcdc: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-13703.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14092.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14285.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14393.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14821.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14845.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14853.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14919.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-14959.rs: pass -> [missing] (J0)
  • [ui] tests/ui/lifetimes/missing-lifetime-specifier-13497.rs: [missing] -> pass (J0)
  • [ui] tests/ui/lifetimes/trait-object-constructor-14821.rs: [missing] -> pass (J0)
  • [ui] tests/ui/match/multiple-refutable-patterns-13867.rs: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/filtering-lending-iterator-issue-92985.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/filtering-lending-iterator-issue-92985.rs#polonius: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/iterating-updating-cursor-issue-108704.rs#nll: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/iterating-updating-cursor-issue-57165.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-123839.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-123839.rs#nll: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-123839.rs#polonius: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-124070.rs#nll: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-51526.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-51545.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-51545.rs#nll: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-54663.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-54663.rs#polonius: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-58787.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-68934.rs#legacy: [missing] -> pass (J0)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-68934.rs#nll: [missing] -> pass (J0)
  • [ui] tests/ui/operator-recovery/box-arithmetic-14915.rs: [missing] -> pass (J0)
  • [ui] tests/ui/resolve/pointer-type-impls-14254.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/trait-bound-mismatch-14853.rs: [missing] -> pass (J0)
  • errors::verify_mir_build_const_continue_unknown_jump_target_33: [missing] -> pass (J3)
  • errors::verify_mir_build_const_continue_unknown_jump_target_34: pass -> [missing] (J3)
  • errors::verify_mir_build_loop_match_arm_with_guard_31: pass -> [missing] (J3)
  • errors::verify_mir_build_loop_match_bad_rhs_29: pass -> [missing] (J3)
  • errors::verify_mir_build_loop_match_bad_statements_28: pass -> [missing] (J3)
  • errors::verify_mir_build_loop_match_invalid_update_24: [missing] -> pass (J3)
  • errors::verify_mir_build_loop_match_missing_assignment_29: [missing] -> pass (J3)
  • errors::verify_mir_build_loop_match_unsupported_type_27: pass -> [missing] (J3)
  • errors::verify_mir_transform_exceeds_mcdc_test_vector_limit_8: pass -> [missing] (J3)
  • errors::verify_monomorphize_abi_error_disabled_vector_type_8: [missing] -> pass (J3)
  • errors::verify_monomorphize_abi_error_unsupported_vector_type_9: [missing] -> pass (J3)
  • errors::verify_monomorphize_abi_required_target_feature_9: pass -> [missing] (J3)
  • errors::verify_monomorphize_encountered_error_while_instantiating_global_asm_6: [missing] -> pass (J3)
  • errors::verify_monomorphize_start_not_found_6: pass -> [missing] (J3)
  • errors::verify_monomorphize_start_not_found_7: [missing] -> pass (J3)
  • char::test_convert_const: [missing] -> pass (J6)

Stage 2

  • [coverage-run] tests/coverage/mcdc/condition-limit.rs: ignore (ignored when the profiler runtime is not available) -> [missing] (J1)
  • [coverage-run] tests/coverage/mcdc/if.rs: ignore (ignored when the profiler runtime is not available) -> [missing] (J1)
  • [coverage-run] tests/coverage/mcdc/inlined_expressions.rs: ignore (ignored when the profiler runtime is not available) -> [missing] (J1)
  • [ui] tests/ui/cast/trait-object-size-error-14366.rs: [missing] -> pass (J2)
  • [ui] tests/ui/generics/box-missing-generics-14092.rs: [missing] -> pass (J2)
  • [ui] tests/ui/inference/matcher-lifetime-inference-14919.rs: [missing] -> pass (J2)
  • [ui] tests/ui/instrument-coverage/coverage-options.rs#mcdc: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-13497-2.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-14091.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-14092.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-14308.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-14875.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-14915.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-14959.rs: pass -> [missing] (J2)
  • [ui] tests/ui/lifetimes/missing-lifetime-specifier-13497.rs: [missing] -> pass (J2)
  • [ui] tests/ui/linkage-attr/linkage-detect-extern-generated-name-collision.rs: pass -> [missing] (J2)
  • [ui] tests/ui/match/multiple-refutable-patterns-13867.rs: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/filtering-lending-iterator-issue-92985.rs#legacy: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/filtering-lending-iterator-issue-92985.rs#polonius: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/iterating-updating-cursor-issue-108704.rs#polonius: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/iterating-updating-cursor-issue-57165.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/iterating-updating-cursor-issue-63908.rs#legacy: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/iterating-updating-cursor-issue-63908.rs#polonius: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-112087.rs#polonius: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-123839.rs#legacy: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-124070.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-124254.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-21906.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-21906.rs#polonius: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-51526.rs#polonius: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-51545.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-58787.rs#legacy: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-58787.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-68934.rs#legacy: [missing] -> pass (J2)
  • [ui] tests/ui/nll/polonius/nll-problem-case-3-issue-68934.rs#nll: [missing] -> pass (J2)
  • [ui] tests/ui/operator-recovery/box-arithmetic-14915.rs: [missing] -> pass (J2)
  • [ui] tests/ui/pattern/array-length-mismatch-verbose-13482.rs: [missing] -> pass (J2)
  • [ui] tests/ui/pattern/struct-mismatch-destructure-14541.rs: [missing] -> pass (J2)
  • [ui] tests/ui/trait-bounds/anonymous-parameters-13775.rs: [missing] -> pass (J2)
  • [assembly] tests/assembly-llvm/targets/targets-elf.rs#armv7a_vex_v5: [missing] -> pass (J4)
  • [coverage-map] tests/coverage/mcdc/inlined_expressions.rs: pass -> [missing] (J4)
  • [coverage-map] tests/coverage/mcdc/nested_if.rs: pass -> [missing] (J4)
  • [coverage-run] tests/coverage/mcdc/condition-limit.rs: pass -> [missing] (J5)
  • [coverage-run] tests/coverage/mcdc/inlined_expressions.rs: pass -> [missing] (J5)

(and 187 additional test diffs)

Additionally, 60 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3634.4s -> 4675.4s (28.6%)
  2. aarch64-apple: 4910.3s -> 5767.8s (17.5%)
  3. x86_64-apple-2: 4924.8s -> 5690.0s (15.5%)
  4. dist-aarch64-apple: 5372.6s -> 6200.1s (15.4%)
  5. dist-x86_64-netbsd: 4626.6s -> 5203.1s (12.5%)
  6. dist-x86_64-apple: 9452.6s -> 8498.1s (-10.1%)
  7. x86_64-apple-1: 7749.9s -> 7011.7s (-9.5%)
  8. pr-check-1: 1796.0s -> 1649.0s (-8.2%)
  9. aarch64-gnu-llvm-19-1: 3681.5s -> 3969.5s (7.8%)
  10. aarch64-gnu-debug: 4470.4s -> 4745.6s (6.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#144400 tests/ui/issues/: The Issues Strike Back [3/N] 5eb13c32d6b53e615331ca562903689d60e2f825 (link)
#144764 [codegen] assume the tag, not the relative discriminant e1b67b6df72230ca0e829febf98f1e0fa8833ccc (link)
#144807 Streamline config in bootstrap 435d5dee1b90c28178cf4dc62963ba455d69ba2d (link)
#144899 Print CGU reuse statistics in -Zprint-mono-items 16da48c9ea94aef1e0e0855bdafb3e0d9f095928 (link)
#144909 Add new test::print_merged_doctests_times used by rustdoc… 6a7aa4e01b868ed69651538f75b6d5a0f6fa5a4e (link)
#144912 Resolver: introduce a conditionally mutable Resolver for (n… a1c636ae604f072d35cdec801db2a3d10eefda7e (link)
#144914 Add support for ty::Instance path shortening in diagnosti… 18b5c035b8df2b7bc4133c295090e2fcfb444ed9 (link)
#144931 [win][arm64ec] Fix msvc-wholearchive for Arm64EC 68697e71134b2d410933f707cdacd341b3ca9e30 (link)
#144999 coverage: Remove all unstable support for MC/DC instrumenta… 90d96610336c972fa051e7ed0aa532c071fcf9b7 (link)
#145009 A couple small changes for rust-analyzer next-solver work 8f23adaee83efa4358d64f7b98ef2e54a0582e16 (link)
#145030 GVN: Do not flatten derefs with ProjectionElem::Index. ae538ba114abdbb0000503fb9701be6e7c4b067d (link)
#145042 stdarch subtree update 9286574df9f536016cd69a2cce563ef0acb0c7b3 (link)
#145047 move type_check out of compute_regions 5293000d4090e25aa5370c34f1cc516f65cae1f9 (link)
#145051 Prevent name collisions with internal implementation details 22c992fe7e465f391844d76a36f3d4e2b4c3e891 (link)
#145053 Add a lot of NLL known-bug tests 46b59a7d7fab10b1a230f2928e8a72eebc830246 (link)
#145055 Move metadata symbol export from exported_non_generic_symbo… 7cecab30f307a645ef5675f8a0b818f606e35509 (link)
#145057 Clean up some resolved test regressions of const trait remo… c8cd8f122461c28b379a9c4e887a107c91a16fa6 (link)
#145068 Readd myself to review queue 252e9a8f6c9529f95c873d079dd2fe56fe99081f (link)
#145070 Add minimal armv7a-vex-v5 tier three target a17f0867a666c195140e6db3c9cce79d487ba248 (link)

previous master: 67d45f49e0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2886b36): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 3
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
-0.4% [-0.6%, -0.2%] 12
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Max RSS (memory usage)

Results (primary -0.9%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)
2.6% [1.3%, 3.8%] 3
Improvements ✅
(primary)
-2.2% [-3.1%, -1.3%] 2
Improvements ✅
(secondary)
-2.3% [-3.3%, -1.2%] 2
All ❌✅ (primary) -0.9% [-3.1%, 1.6%] 3

Cycles

Results (secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.4%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 1
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
-0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.8%, 0.0%] 2

Bootstrap: 464.119s -> 465.538s (0.31%)
Artifact size: 377.50 MiB -> 377.38 MiB (-0.03%)

@Kobzol
Copy link
Member

Kobzol commented Aug 12, 2025

The tt-muncher wins are maybe noise, but overall it's a wash anyway.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 12, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 12, 2025
Rollup of 19 pull requests

Successful merges:

 - rust-lang#144400 (`tests/ui/issues/`: The Issues Strike Back [3/N])
 - rust-lang#144764 ([codegen] assume the tag, not the relative discriminant)
 - rust-lang#144807 (Streamline config in bootstrap)
 - rust-lang#144899 (Print CGU reuse statistics in `-Zprint-mono-items`)
 - rust-lang#144909 (Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information)
 - rust-lang#144912 (Resolver: introduce a conditionally mutable Resolver for (non-)speculative resolution.)
 - rust-lang#144914 (Add support for `ty::Instance` path shortening in diagnostics)
 - rust-lang#144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC)
 - rust-lang#144999 (coverage: Remove all unstable support for MC/DC instrumentation)
 - rust-lang#145009 (A couple small changes for rust-analyzer next-solver work)
 - rust-lang#145030 (GVN:  Do not flatten derefs with ProjectionElem::Index. )
 - rust-lang#145042 (stdarch subtree update)
 - rust-lang#145047 (move `type_check` out of `compute_regions`)
 - rust-lang#145051 (Prevent name collisions with internal implementation details)
 - rust-lang#145053 (Add a lot of NLL `known-bug` tests)
 - rust-lang#145055 (Move metadata symbol export from exported_non_generic_symbols to exported_symbols)
 - rust-lang#145057 (Clean up some resolved test regressions of const trait removals in std)
 - rust-lang#145068 (Readd myself to review queue)
 - rust-lang#145070 (Add minimal `armv7a-vex-v5` tier three target)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.